fix(wpc-154): add numeric input buttons type #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortiz-coveo
requested review from
a team,
GermainBergeron and
gdostie
and removed request for
a team
tortiz-coveo
commented
Dec 5, 2023
gdostie
approved these changes
Dec 5, 2023
GermainBergeron
approved these changes
Dec 5, 2023
GermainBergeron
deleted the
fix/wpc-154/add-numeric-input-buttons-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds the button types to the plus and minus numeric input buttons. This avoids premature default validations on the form when clicking on those buttons. Currently the default type of the button is submit and triggers validations on every button press. This behavior manifests itself by showing a
Please fill out this fieldalert on every button press on forms where empty inputs are present in the form. Here's a stack overflow post describing the issue