Ad UI 9399 fix get input props #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixBlaisThon
requested review from
a team,
GermainBergeron and
aboissinot-coveo
and removed request for
a team
gdostie
reviewed
Jan 8, 2024
FelixBlaisThon
force-pushed
the
ADUI-9399-fix-getInputProps
branch
2 times, most recently
from
df8b5ea to
31dd2a0
Compare
FelixBlaisThon
force-pushed
the
ADUI-9399-fix-getInputProps
branch
from
e8b9ca2 to
96a485a
Compare
gdostie
approved these changes
Jan 8, 2024
aboissinot-coveo
approved these changes
Jan 9, 2024
GermainBergeron
pushed a commit
that referenced
this pull request
Feb 19, 2024
* chore(mantine): bump to mantine v7, first commit rebasing * chore(mantine): lots of css modules, preparing theme and components rebasing * chore(mantine)!: more breaking stuff * chore(mantine)!: more module, less v6, build working * chore(mantine)!: trying to style my branch so it looks 1:1 with master * chore(mantine)!: apply some visual fixes to look like prod * chore(mantine)!: fixed table style and rows * chore(mantine)!: fixed all the rest style expect table gutter grid * chore(mantine)!: fix interfaces and remove comments * chore(useForm)!: change condition in useform hook * chore(useForm)!: fixed collection demo * chore(useForm): fixed ternary and faker-js * chore(useForm): removed console.log * chore(useForm)!: fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added opt-in type in
getInputProps()so that thereorder, remove and insertmethod are only eposed forcollectiontype.Potential Breaking Changes
It will break all collection that uses those 3 methods, since they do not explicitly specify the type that is now required to get those methods
I point it to next since it will get added to the new mantine 7 breaking change
Acceptance Criteria