Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mantine): make table root have 100% width #3965

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

gdostie
Copy link
Collaborator

@gdostie gdostie commented Nov 26, 2024

Proposed Changes

For most implementations, this fix will be transparent. It mostly impacts tables that are displayed within a flex container. In this situation, the table will take the full with of that flex container instead of minimally fitting the content of the table.

Example

If we imagine the following component:

<Box display="flex">
    <Table {...} />
</Box>

Before

image

After

image

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

Copy link

@gdostie gdostie marked this pull request as ready for review November 26, 2024 15:51
@gdostie gdostie requested a review from a team as a code owner November 26, 2024 15:51
@gdostie gdostie requested review from GermainBergeron and FelixBlaisThon and removed request for a team November 26, 2024 15:51
@gdostie gdostie merged commit 19f2547 into master Nov 27, 2024
6 checks passed
@gdostie gdostie deleted the table-root-full-width branch November 27, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants