Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mantine): remove a lot of custom style to get a vanilla style #3986

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

GermainBergeron
Copy link
Member

@GermainBergeron GermainBergeron commented Dec 17, 2024

Proposed Changes

This PR is a first step to simplify and streamline the library by removing unnecessary customizations and aligning the library with a near-vanilla implementation of Mantine.

The UX team started using Pretine’s Figma library and it provides practically the same level of customization has Mantine does (via the Theme and component variables).

I divided the commits of this PR:

  • Cleanup the style, remove a lot of unnecessary customization
  • Add semantic components (ButtonPrimary, ButtonSecondary, ..., AlertWarning, AlertTip, ... etc) instead of having to rely on knowledge of the variant and colors
  • Update the website to allow dark theme and changing the primary color

Potential Breaking Changes

A lot of minor changes to the style

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

Copy link

@GermainBergeron GermainBergeron force-pushed the feat/mantine-minimal-style branch from 1dc32ac to 25cedec Compare December 17, 2024 21:04
@GermainBergeron GermainBergeron force-pushed the feat/mantine-minimal-style branch from 25cedec to aa70f2a Compare December 18, 2024 20:33
@GermainBergeron GermainBergeron force-pushed the feat/mantine-minimal-style branch from aa70f2a to 879baf1 Compare December 18, 2024 21:21
@GermainBergeron GermainBergeron changed the base branch from master to next December 19, 2024 14:43
@GermainBergeron GermainBergeron marked this pull request as ready for review December 19, 2024 14:48
@GermainBergeron GermainBergeron requested a review from a team as a code owner December 19, 2024 14:48
@GermainBergeron GermainBergeron requested review from gdostie and FelixBlaisThon and removed request for a team December 19, 2024 14:48
@gdostie gdostie merged commit 354db73 into next Jan 2, 2025
6 checks passed
@gdostie gdostie deleted the feat/mantine-minimal-style branch January 2, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants