Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mantine,table): make table predicate scroll more visible #3999

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

gdostie
Copy link
Collaborator

@gdostie gdostie commented Jan 20, 2025

Proposed Changes

Before

Screen.Recording.2025-01-20.at.4.43.24.PM.mov

After

Screen.Recording.2025-01-20.at.4.42.39.PM.mov

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

Copy link

@gdostie gdostie marked this pull request as ready for review January 20, 2025 21:53
@gdostie gdostie requested a review from a team as a code owner January 20, 2025 21:53
@gdostie gdostie requested review from FelixBlaisThon and toofff and removed request for a team January 20, 2025 21:53
FelixBlaisThon
FelixBlaisThon previously approved these changes Jan 21, 2025
@FelixBlaisThon
Copy link
Collaborator

Code is ok, but I don't see it on the demo
image

Is the demo brokened ?

@FelixBlaisThon FelixBlaisThon dismissed their stale review January 21, 2025 13:25

demo not working

Copy link
Collaborator

@FelixBlaisThon FelixBlaisThon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brain not working

@gdostie gdostie merged commit 78111ca into master Jan 21, 2025
6 checks passed
@gdostie gdostie deleted the ADUI-10421-make-table-predicate-scroll-more-visible branch January 21, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants