-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(atomic): add heading function for lit components #4861
base: master
Are you sure you want to change the base?
Conversation
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
ATM this PR actually renames both The hidden renamal seems out of scope, but I guess it will have to be done anyways, so it's not a big deal. |
Co-authored-by: Frederic Beaudoin <[email protected]>
Yeah, sorry. It was something I forgot to do in previous PRs |
@@ -0,0 +1,33 @@ | |||
// import {spread} from '@open-wc/lit-helpers'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
part?: string; | ||
} | ||
|
||
// TODO: KIT-3822: add unit tests to this function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- unit tests
heading
function to replace the<Heading>
functional component.hidden.tsx
function component tostencil-hidden.tsx
(to be consistent)Usage
with Stencil
with Lit
Notes
Using
unsafeStatic
since we need to interpolate non-literal statics.https://coveord.atlassian.net/browse/KIT-3833