-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(atomic): add tests to binding decorators #4911
base: master
Are you sure you want to change the base?
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
packages/atomic/src/utils/initialization-lit-stencil-common-utils.spec.ts
Outdated
Show resolved
Hide resolved
expect(renderSpy).toHaveBeenCalledTimes(initialRenderCalls + 1); | ||
}); | ||
|
||
it('should not call the original render function', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could group this test and the two that follow it under the same describe
describe('when there is an error', () => {
it('should not call the original render function', async () => {
// ...
});
it('should console log the error message', async () => {
// ...
})
it('should render the error message', async () => {
// ...
});
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to adjust the atomic and angular scripts to ignore spec.ts files because they are trying to add all of your test elements 😆
Co-authored-by: Frederic Beaudoin <[email protected]>
fetchBindings
into separate filehttps://coveord.atlassian.net/browse/KIT-3901