fix(explorer): cast string SupportedChainId to number #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
approved these changes
Jan 14, 2024
elena-zh
approved these changes
Jan 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3621
Properly identify gchain network id and use the correct rpc provider (not infura).
To Test
0xf8def1173a59451d5d2d5db2f57cfabe5cfa3ad0cd6d8d63e602dc66bb1e76d35b0abe214ab7875562adee331deff0fe1912fe4265aa8bddBackground
The code was ignoring TS and casting the SupportedChainId enum value (number) to the type itself.
In the end, this check was failing because
'100' !== 100cowswap/apps/explorer/src/api/web3/index.ts
Line 93 in d744c4a