feat: add loading logo for hook

[fairlighteth]

Summary

• Addresses [1.89] Improve loader for iFrame hook #5098

Screen.Recording.2024-11-19.at.17.47.03.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
cosmos	✅ Ready (Inspect)	Visit Preview	Nov 20, 2024 4:49pm
cowfi	✅ Ready (Inspect)	Visit Preview	Nov 20, 2024 4:49pm
explorer-dev	✅ Ready (Inspect)	Visit Preview	Nov 20, 2024 4:49pm
swap-dev	✅ Ready (Inspect)	Visit Preview	Nov 20, 2024 4:49pm
widget-configurator	✅ Ready (Inspect)	Visit Preview	Nov 20, 2024 4:49pm

[elena-zh]

Hey @fairlighteth , I like the new loader very much!
One question: is this OK that sometimes 1 loader is changed to another one? See the video: https://www.loom.com/share/7d9847e1c6f44eb1bc992f76ef2d996c

I've also provided you a video with steps I do for the second case reported in #5098 (comment)

[fairlighteth]

@elena-zh thanks for reviewing

1. So what happens is that for external hooks (loaded using an Iframe) we show a loading logo before the iframe is loaded. The second circular spinner you see, actually comes from the externally loaded hook (iframe) itself and is not something that is controlled in the CoW Swap app.

2. Thanks for the clarification, I will review this.

[fairlighteth]

@elena-zh please check the tooltip issue, this should be resolved now.

[elena-zh]

LGTM!

[elena-zh]

@fairlighteth , I've noticed the button has become shifted on the confirm modal on the Hooks tab:

This is not yet reproducible in Dev:

Could you please fix it here?

[fairlighteth]

@elena-zh should be fixed now:

[elena-zh]

Thank you for addressing this!

[shoom3301]

Awesome!