feat: use new deterministic ethflow contracts #5334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
anxolin
force-pushed
the
update-eth-flow-contracts
branch
from
9ec74e6 to
696a633
Compare
alfetopito
reviewed
Jan 31, 2025
alfetopito
approved these changes
Feb 5, 2025
anxolin
force-pushed
the
update-eth-flow-contracts
branch
from
52fb6a3 to
9ba727a
Compare
shoom3301
reviewed
Feb 6, 2025
| @@ -72,7 +80,7 @@ export async function ethFlow( | |||
| throw new Error('Quote expired. Please refresh.') | |||
| } | |||
|
|
|||
| if (contract.address !== COWSWAP_ETHFLOW_CONTRACT_ADDRESS_MAP[chainId as SupportedChainId]) { | |||
| if (contract.address !== getEthFlowContractAddresses(ethFlowEnv, useNewEthFlowContracts, chainId)) { | |||
There was a problem hiding this comment.
Should we add .toLowerCase() here?
There was a problem hiding this comment.
Sorry I saw this before merging. It didn't have if before, but it may be wise. I can address in develop (as this works without the change, if something, is in case a future library of ethers breaks this logic)
shoom3301
approved these changes
Feb 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is in preparation for the ETH FLOW migration. We will replace BARN and PROD eth flow contracts with some new version deployed in deterministic address (same address to all networks).
This is done to minimize the risk of sending ETH to the wrong address in case of a Dapp or Wallet bug.
Context
Tracker for the changes https://www.notion.so/cownation/tracker-ETH-Flow-Contract-Replacements-1828da5f04ca8023af57e76cf6d064d9?pvs=4
See the new deployment and more context:
cowprotocol/ethflowcontract#59
Test
Test old contracts
With he feature flag off, make sure it uses the old barn contracts:
{ "1": "0xD02De8Da0B71E1B59489794F423FaBBa2AdC4d93", "100": "0xD02De8Da0B71E1B59489794F423FaBBa2AdC4d93", "11155111": "0x2671994c7D224ac4799ac2cf6Ef9EF187d42C69f", "42161": "0x6dfe75b5ddce1ade279d4fa6bd6aef3cbb6f49db", "5": "0xD02De8Da0B71E1B59489794F423FaBBa2AdC4d93", "8453": "0x3C3eA1829891BC9bEC3d06A81d5d169e52a415e3" }Test the new flag
If we enable the flag, it should use
0x04501b9b1d52e67f6862d157e00d13419d2d6e95no matter which network.Test new contracts
We could set the flag to
true, but because multiple teams are using this PR, we might be affecting each other#5358
Details on what to test
Test flows:
How to change the flag: