feat: warn users about metamask transactions #5362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
shoom3301
commented
Jan 31, 2025
| const priceImpactIsHighEnough = +priceImpact.toFixed(2) > PRICE_IMPACT_LIMIT | ||
| const buyAmountIsBigEnough = +(buyingFiatAmount?.toExact() || 0) > AMOUNT_LIMIT[chainId] | ||
|
|
||
| const shouldSuggestTwap = !isSellNative && priceImpactIsHighEnough && buyAmountIsBigEnough |
There was a problem hiding this comment.
A small enhancement: do not show the twap suggestion banner when selling ETH
alfetopito
approved these changes
Jan 31, 2025
apps/cowswap-frontend/src/modules/trade/containers/WrapFlowActionButton/index.tsx
Show resolved
Hide resolved
alfetopito
reviewed
Jan 31, 2025
...wswap-frontend/src/modules/tradeWidgetAddons/containers/MetamaskTransactionWarning/index.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit
Updated message:
Summary
Fixes: https://docs.google.com/document/d/1q4R99t3BQlX_n7cEZlG0PzOvepg6kxsyatm2VxGANG4/edit?tab=t.0#heading=h.wjw6vqd8yw40
The banner should be displayed only when
To Test