fix: tooltip placement inside an order in cow explorer #5400

vnaysngh · 2025-02-05T19:14:53Z

Partial Fix for #5105

This PR addresses the incorrect tooltip placement when clicking inside an order, specifically on the Submission Time, Execution Time, and Expiration Time fields.

Before fix

After fix

Key Changes & Observations

Previously, tooltips appeared when clicking either the clock icon or the date. In this fix, they only trigger when clicking the icon. However, if the icon is hidden, clicking the date will still display the tooltip.
Tooltips remain visible on the screen at the same time without automatically closing. Is this intended behavior? (Check the image below.)

@elena-zh

Summary by CodeRabbit

Refactor
- Improved the structure of the date display component. The update reorganizes how date information, icons, and tooltips are presented, while ensuring the visual output remains identical. This internal refinement streamlines future maintenance and does not alter any functionality that users interact with. End-users will notice no differences during usage.

vercel · 2025-02-05T19:15:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
explorer-dev	✅ Ready (Inspect)	Visit Preview	Feb 7, 2025 3:29pm

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
sdk-tools	⬜️ Ignored (Inspect)	Visit Preview	Feb 7, 2025 3:29pm

vercel · 2025-02-05T19:15:01Z

@vnaysngh is attempting to deploy a commit to the cow Team on Vercel.

A member of the Team first needs to authorize it.

elena-zh · 2025-02-06T08:36:39Z

Hey @vnaysngh , thank you for your contribution (again!)
Changes LGTM, however:

Previously, tooltips appeared when clicking either the clock icon or the date. In this fix, they only trigger when clicking the icon. However, if the icon is hidden, clicking the date will still display the tooltip.

I wouldn't change the current behavior and leave the date clickable

Tooltips remain visible on the screen at the same time without automatically closing. Is this intended behavior? (Check the image below.)

Yes, it is an expected behavior.

Thanks!

vnaysngh · 2025-02-06T10:00:26Z

I wouldn't change the current behavior and leave the date clickable

I have updated the code. Thank you.

elena-zh · 2025-02-06T10:04:12Z

I wouldn't change the current behavior and leave the date clickable

I have updated the code. Thank you.

Should it still be in a draft? :)

…explorer

elena-zh

Thank you, looks good to me now :)

anxolin · 2025-02-07T15:04:41Z

apps/explorer/src/components/common/DateDisplay/index.tsx

-      ) : (
-        <span {...targetProps}>{previewDate}</span>
-      )}
+      <span className="d-flex">


Where is this d-flex coming from?

It is not needed. I have removed it. Thank you :)

coderabbitai · 2025-02-07T15:29:18Z

Walkthrough

The change refactors the DateDisplay component in apps/.../DateDisplay/index.tsx by adding an extra nested span around the IconWrapper when the showIcon prop is true. The update restructures the HTML output without altering the tooltip functionality or date formatting, keeping the overall behavior consistent.

Changes

File	Summary
apps/.../DateDisplay/index.tsx	Added an extra nested span around IconWrapper for the showIcon condition; no behavior change.

Poem

In the barn of our code, a small tweak did bloom,
A nested span now shelters the icon with room.
No change in date or tip—just structure so neat,
A gentle moo of progress, steady and sweet.
Happy coding under the wide, starry sky—moo!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8f6b87 and 05c50d5.

📒 Files selected for processing (1)

apps/explorer/src/components/common/DateDisplay/index.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

apps/explorer/src/components/common/DateDisplay/index.tsx

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Cypress
GitHub Check: Setup

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

fix: tooltip placement inside an order in cow explorer

07f28b5

vercel bot deployed to Preview – explorer-dev February 6, 2025 08:28 View deployment

fix: expanded click area for date display tooltip

6d4056f

vnaysngh marked this pull request as ready for review February 6, 2025 10:05

elena-zh requested review from a team February 6, 2025 10:20

Merge branch 'develop' into fix/tooltip-placement-inside-an-order-in-…

7ce2702

…explorer

vercel bot deployed to Preview – explorer-dev February 7, 2025 09:13 View deployment

elena-zh mentioned this pull request Feb 7, 2025

Improve Explorer home page layout #5105

Open

elena-zh approved these changes Feb 7, 2025

View reviewed changes

anxolin reviewed Feb 7, 2025

View reviewed changes

fix: remove d-flex property from span in date display

05c50d5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: tooltip placement inside an order in cow explorer #5400

fix: tooltip placement inside an order in cow explorer #5400

vnaysngh commented Feb 5, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 5, 2025 •

edited

Loading

vercel bot commented Feb 5, 2025

elena-zh commented Feb 6, 2025

vnaysngh commented Feb 6, 2025

elena-zh commented Feb 6, 2025

elena-zh left a comment

anxolin Feb 7, 2025

vnaysngh Feb 7, 2025

coderabbitai bot commented Feb 7, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

fix: tooltip placement inside an order in cow explorer #5400

Are you sure you want to change the base?

fix: tooltip placement inside an order in cow explorer #5400

Conversation

vnaysngh commented Feb 5, 2025 • edited by coderabbitai bot Loading

Before fix

After fix

Key Changes & Observations

Summary by CodeRabbit

vercel bot commented Feb 5, 2025 • edited Loading

vercel bot commented Feb 5, 2025

elena-zh commented Feb 6, 2025

vnaysngh commented Feb 6, 2025

elena-zh commented Feb 6, 2025

elena-zh left a comment

Choose a reason for hiding this comment

anxolin Feb 7, 2025

Choose a reason for hiding this comment

vnaysngh Feb 7, 2025

Choose a reason for hiding this comment

coderabbitai bot commented Feb 7, 2025 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

vnaysngh commented Feb 5, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 5, 2025 •

edited

Loading

coderabbitai bot commented Feb 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)