ci: Sign Windows binary on master only #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
force-pushed
the
ci/sign-windows-binary-only-on-master
branch
2 times, most recently
from
ee99765 to
725b84a
Compare
taratatach
changed the title
nono
approved these changes
Sep 9, 2024
taratatach
force-pushed
the
ci/sign-windows-binary-only-on-master
branch
7 times, most recently
from
a921720 to
843baee
Compare
Since we switched to using DigiCert's cloud HSM for code signing certificate storage (the other option being using a hardware token), we have been limited to 1000 code signatures per year. We could increase the number of allowed signatures at a cost. We choose to stop signing binaries generated by Pull Requests as they're not published.
taratatach
force-pushed
the
ci/sign-windows-binary-only-on-master
branch
from
843baee to
22af359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we switched to using DigiCert's cloud HSM for code signing
certificate storage (the other option being using a hardware token),
we have been limited to 1000 code signatures per year.
We could increase the number of allowed signatures at a cost.
We choose to stop signing binaries generated by Pull Requests as
they're not published.
Please make sure the following boxes are checked: