fix: Setup Sentry fingerprint for errors only #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help Sentry group similar errors together, we set the message fingerprint ourselves with the error's name and message and the originating logger name. However, if we trying to send a message to Sentry without an error (i.e. we logged a message with the `sentry: true` option), trying to get its name or message will throw an error for trying to get attributes of `undefined`. Therefore, we'll set the fingerprint manually only when sending a message related to an error.
taratatach
force-pushed
the
fix/sentry-errors-fingerprint-setup
branch
from
c93b33e to
2d781d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help Sentry group similar errors together, we set the message
fingerprint ourselves with the error's name and message and the
originating logger name.
However, if we trying to send a message to Sentry without an error
(i.e. we logged a message with the
sentry: trueoption), trying toget its name or message will throw an error for trying to get
attributes of
undefined.Therefore, we'll set the fingerprint manually only when sending a
message related to an error.
Please make sure the following boxes are checked: