test: Prevent excessive errors during tests #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
force-pushed
the
feat/add-suspend-resume-actions-to-watchers
branch
from
2f30015 to
1c38a40
Compare
taratatach
force-pushed
the
test/prevent-excessive-errors
branch
from
6ffc29f to
090aeff
Compare
taratatach
force-pushed
the
feat/add-suspend-resume-actions-to-watchers
branch
from
1c38a40 to
10c7343
Compare
Some tests are the cause of errors (while not turning red) as they start background processings which are not stopped at the end of the tests and end up trying to access a destroyed database. Stopping these processings will prevent those errors and might improve test performance.
taratatach
force-pushed
the
test/prevent-excessive-errors
branch
from
090aeff to
54f5cce
Compare
taratatach
changed the base branch from
feat/add-suspend-resume-actions-to-watchers
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are the cause of errors (while not turning red) as they
start background processings which are not stopped at the end of the
tests and end up trying to access a destroyed database.
Stopping these processings will prevent those errors and might improve
test performance.
Please make sure the following boxes are checked: