Add idFromLibrary and creationDateFromLibrary in io.cozy.files metadata for backup #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
query string Adding metadata when uploading a file was done by creating a metadata object and passing the metadata object id during the file upload. I switch to pass the metadata object directly in query string. I did not do it like this before because it was considered as a deprecated method. After discussion with the cozy-stack team, it is now only a not recommended method. We just need to be careful with the size of the metadata object. In the backup feature, we are really interested by the metadata in query string way because it can reduce a lot the number of request sent to the server. Especially because we will in a next commit add an id and a creationDate in the metadata object, so every metadata object will be different and it will not be possible to reuse metadata object id anymore.
We will be able to use these values to compare if two pictures are the same locally. These values will not be changed by the stack, contrary to created_at value.
This date will never be changed. So it is much safer.
zatteo
changed the title
Crash--
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add idFromLibrary and creationDateFromLibrary in io.cozy.files metadata for backup
=> these id and date will never be changed by the stack so we can trust them
=> it will solve issues where two identical pictures were not seen as identical by the backup because the date was changed by the stack
Also changes the way we send metadata
I will create a PR later for react-native-camera-roll