fix: Log Konnector failure log on errors which occur before fetch step with no account #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 27, 2023 16:22
Even if no account and job exists yet without it we potentially miss many errors in our statistics
Could not activate ts-check yet because there a lot more errors but making progress.
LucsT
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not have a "Konnector failure: ..." log when an error happened before the fetch step (ensureAuthenticated, getUserDataFromWebsite) and when the account, trigger and job did not exist yet
Since we use this log to supervise the execution of clisk konnectors, we need it in this case too.
Checklist
Before merging this PR, the following things must have been done: