fix: handle race condition in resetUiState #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acezard
force-pushed
the
fix--handle-race-condition-in-resetUiState
branch
2 times, most recently
from
b27e22b to
d6be0fd
Compare
acezard
force-pushed
the
fix--handle-race-condition-in-resetUiState
branch
from
d6be0fd to
8c4e234
Compare
using dirty hack to fix prod build with no side effects If files to upload, then resetUIState will use dark icons instead of home theme
acezard
force-pushed
the
fix--handle-race-condition-in-resetUiState
branch
from
8c4e234 to
fa367a2
Compare
Crash--
approved these changes
Dec 5, 2023
Ldoppea
added a commit
that referenced
this pull request
Dec 18, 2023
Ldoppea
added a commit
that referenced
this pull request
Dec 18, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 18, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 19, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Dec 20, 2023
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Jan 4, 2024
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Ldoppea
added a commit
that referenced
this pull request
Jan 5, 2024
Now that OsReceive uses the new FlagshipUI API, then this hack is not needed anymore Related PR: #1043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is meant to be a temporary solution to fix an issue where
resetUIstatehas to know the state of this feature before executing its logic. Still, at the time of writing,resetUIStatehas no connection to the React tree.ResetUIStateshould be refactored to use a proper React context. It can't be done during this commit for time constraints.