Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Efforts to support latest tflite-micro #71

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

PhilippvK
Copy link

@PhilippvK PhilippvK commented Aug 22, 2022

For reference here is a summary of my past efforts to get TFLMC running with current tflite-micro. This heavily depends on @andrewstevens-infineon works over the past two years and should mainly be for reference and to compare with the approach used in #70.

I've tried to strip down the changes to the bare essentials, removing all IFX-related boilerplate code as well as the history as I am not sure if these should be available upstream.

On top of that I fixed the Cake configuration to build the custom tflite-micro lib (no need to use the tflite-micro Makefile) anymore.

To use this codebase, a patched tflite-micro codebase is required. See my branch feature/tflmc_support2 (Diff) for reference. It builds up on upstream commit 17b795d4233844144624df04c11ca1d967e81033 and the impressive work of @andrewstevens-infineon. Again, I cut the changes down to only the minimum required for the preinterpretation (adding hooks to records allocations etc.)

I do not want to merge this as-is. The main work was done by the people around @andrewstevens-infineon. My contribution was "just" digging through all the changes and pick/cleanup them to generate a meaningful diff as shown below.

@PhilippvK PhilippvK changed the title Efforts to support latest tflite-micro Draft: Efforts to support latest tflite-micro Aug 22, 2022
@PhilippvK
Copy link
Author

CC @rafzi @panickal-xmos

@panickal-xmos
Copy link

Thank you @PhilippvK! :) Brilliant that you have put up the changes. Will have a look through the PR.

@panickal-xmos
Copy link

The upstream commit on which the patch is based is mentioned as 17b795d4233844144624df04c11ca1d967e81033 which seems to be a fork of tflite-micro. Has this been selected for some reason?

@PhilippvK
Copy link
Author

The upstream commit on which the patch is based is mentioned as 17b795d4233844144624df04c11ca1d967e81033 which seems to be a fork of tflite-micro. Has this been selected for some reason?

Oh, this was just a copy-paste mistake from my side. I updated the URL to point to the upstream repository instead: tensorflow/tflite-micro@17b795d

@andrewstevens-infineon
Copy link
Collaborator

Hi Philipp,

Thanks for taking the initiative on this. I'm currently refactoring / cleaning up on our side. The aim is to move the IFX-specific stuff as a changeset on top of your version which will be the mainline. I'll see if I can walk through a diff of the current status to see where we may need to align/sync up to resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants