Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BundleToResources adjustment and optimization #543

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

BundleToResources adjustment and optimization #543

wants to merge 10 commits into from

Conversation

echicoine-icf
Copy link
Contributor

@echicoine-icf echicoine-icf commented Jan 14, 2025 •
edited
Loading

Changes:

  • Retain folder structure to easily trace source of extracted resources
  • Added new argument handling to delete bundles after operation completes: -db=true
  • Added new BundleToResources test to account for new delete bundle argument
  • Optimized code to handle large file loads
  • Adjusted ThreadUtils after discovering macOS/linux does not handle cached executor as Windows does. Executor set to fixed thread pool (cpu core count * 2)

https://icf.atlassian.net/browse/CQF-2407

  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

echicoine-icf and others added 10 commits January 5, 2025 15:29
@echicoine-icf
Outputting to folders named after the initial bundle. Still more work…
2ed1385 
… to do, checking in progress.
@echicoine-icf
Maintaining complete folder structure including subdirectories.
548a439
@echicoine-icf
Cleaned up the output a bit, added some logical rules for when to ski…
af9632f 
…p processing of files (not json or xml, or matches output path)
@echicoine-icf
Multithreaded support added and adjusted default Executor in ThreadUt…
3913b66 
…ils to avoid memory issues on macos
saving
6d4ec2b
Removed folder structure where files are extracted to a folder named …
b0c4317 
…after the bundle, but folder structure of where files originate from is retained.
Adjusting the ThreadUtils thread pool count
546976c
Optimized BundleToResources, added new argument db (delete bundles) t…
a0b19a2 
…o run use -db=true, updated test with new delete feature.
Cleanup
a63b0d7
Correcting some path issues stemming from a windows vs macos file sys…
2ceda28 
…tem. Also correcting an issue where a reused instance of BundleToResources() was erroneously passing in -db=true to a test that shouldn't have it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@echicoine-icf