show read-only settings when allowAdminChanges is false

composer.json

@@ -30,7 +30,7 @@
   "prefer-stable": true,
   "require": {
     "php": "^8.2",
-    "craftcms/cms": "^5.0.0-beta.2",
+    "craftcms/cms": "^5.6.0",
     "cakephp/utility": "^5.0.0",
     "jakeasmith/http_build_url": "^1.0",
     "nesbot/carbon": "^2.10|^3.0.0",

src/Plugin.php

@@ -66,6 +66,11 @@ public static function config(): array
     public bool $hasCpSettings = true;
     public bool $hasCpSection = true;
 
+    /**
+     * @inheritdoc
+     */
+    public bool $hasReadOnlyCpSettings = true;
+
     /**
      * @var Queue|array|string
      * @since 4.5.0
@@ -108,6 +113,14 @@ public function getSettingsResponse(): mixed
         return Craft::$app->controller->redirect(UrlHelper::cpUrl('feed-me/settings'));
     }
 
+    /**
+     * @inheritdoc
+     */
+    public function getReadOnlySettingsResponse(): mixed
+    {
+        return Craft::$app->getResponse()->redirect(UrlHelper::cpUrl('feed-me/settings'));
+    }
+
     public function getPluginName(): string
     {
         return Craft::t('feed-me', $this->getSettings()->pluginName);

src/controllers/BaseController.php

@@ -23,12 +23,13 @@ class BaseController extends Controller
      */
     public function actionSettings(): Response
     {
-        $this->requireAdmin();
+        $this->requireAdmin(false);
 
         $settings = Plugin::$plugin->getSettings();
 
         return $this->renderTemplate('feed-me/settings/general', [
             'settings' => $settings,
+            'readOnly' => !Craft::$app->getConfig()->getGeneral()->allowAdminChanges,
         ]);
     }
 

src/templates/settings/general.html

@@ -1,10 +1,15 @@
-{% requireAdmin %}
+{% requireAdmin false %}
 
 {% extends 'feed-me/_layouts/settings' %}
 
 {% import '_includes/forms' as forms %}
 
-{% set fullPageForm = true %}
+{% set readOnly = readOnly ?? false %}
+{% set fullPageForm = not readOnly %}
+
+{% if readOnly %}
+    {% set contentNotice = readOnlyNotice() %}
+{% endif %}
 
 {% block content %}
     <input type="hidden" name="action" value="plugins/save-plugin-settings">
@@ -20,6 +25,7 @@
         first: true,
         autofocus: true,
         instructions: 'Plugin name for the end user.'|t('feed-me'),
+        disabled: readOnly,
     }) }}
 
     {{ forms.textField({
@@ -28,6 +34,7 @@
         label: 'Cache Duration'|t('feed-me'),
         value: settings.cache,
         instructions: 'Cache duration (in seconds) to cache requests. Note: this only affects calls using the template tag - requests are never cached when triggering directly via the CP.'|t('feed-me'),
+        disabled: readOnly,
     }) }}
 
     <hr>
@@ -45,6 +52,7 @@
         },
         values: settings.enabledTabs,
         instructions: 'Choose which tabs you would like to be shown.'|t('feed-me'),
+        disabled: readOnly,
     }) }}
 
     {% endnamespace %}

src/web/twig/variables/FeedMeVariable.php

@@ -65,7 +65,7 @@ public function getTabs(): array
             'utilities' => ['label' => Craft::t('feed-me', 'Utilities'), 'url' => UrlHelper::cpUrl('feed-me/utilities')],
         ];
 
-        if (Craft::$app->getUser()->getIsAdmin() && Craft::$app->getConfig()->getGeneral()->allowAdminChanges) {
+        if (Craft::$app->getUser()->getIsAdmin()) {
             $tabs['settings'] = ['label' => Craft::t('feed-me', 'Settings'), 'url' => UrlHelper::cpUrl('feed-me/settings')];
         }