Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit serde/serde_json from lockfiles not using cargo_metadata #79

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Jan 3, 2025

This will work just as well for forcing a good minimal version when clap-cargo's "cargo_metadata" feature is enabled, but it keeps serde and serde_json and itoa and memchr and ryu and serde_derive out of downstream Cargo.lock that wouldn't otherwise need them.

@epage epage enabled auto-merge January 3, 2025 02:56
@coveralls
Copy link

coveralls commented Jan 3, 2025

Pull Request Test Coverage Report for Build 12592025062

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 12587387185: 0.0%
Covered Lines: 0
Relevant Lines: 29

💛 - Coveralls

auto-merge was automatically disabled January 3, 2025 02:57

Head branch was pushed to by a user without write access

@epage epage enabled auto-merge January 3, 2025 03:30
@epage epage merged commit a37548f into crate-ci:master Jan 3, 2025
16 of 17 checks passed
@dtolnay dtolnay deleted the deps branch January 3, 2025 03:32
dtolnay added a commit to dtolnay/cargo-llvm-lines that referenced this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants