Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strip prefix #397

Merged
merged 2 commits into from
Dec 18, 2024
Merged

feat: strip prefix #397

merged 2 commits into from
Dec 18, 2024

Conversation

JP-Ellis
Copy link
Contributor

@JP-Ellis JP-Ellis commented Sep 19, 2024

If fixups are allowed, then the remainder of the commit message ought to either be either a previous commit's subject line, or a hash:

If a commit message starts with "squash! ", "fixup! " or "amend! ", the remainder of the subject line is taken as a commit specifier, which matches a previous commit if it matches the subject line or the hash of that commit.

So we can either:

  1. Assume that previous commit's subject line was previously validated and do nothing further; or,
  2. Validate the remainder of the commit's subject line as is.

This specific implementation opts for the latter.

Resolves #392

@JP-Ellis JP-Ellis mentioned this pull request Sep 19, 2024
@coveralls
Copy link

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 12395677344

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 4.948%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/committed/src/checks.rs 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
crates/committed/src/checks.rs 1 1.79%
Totals Coverage Status
Change from base Build 12125583972: -0.05%
Covered Lines: 24
Relevant Lines: 485

💛 - Coveralls

@JP-Ellis JP-Ellis force-pushed the feat/strip-fixup branch 2 times, most recently from 3714335 to 3068f40 Compare December 18, 2024 05:56
@JP-Ellis
Copy link
Contributor Author

I've rebased this PR on top of master in case you're still interested in merging this.

epage and others added 2 commits December 18, 2024 09:03
If fixups are allowed, then the remainder of the commit message ought to
either be either a previous commit's subject line, or a hash:

> If a commit message starts with "squash! ", "fixup! " or "amend! ",
> the remainder of the subject line is taken as a commit specifier,
> which matches a previous commit if it matches the subject line or the
> hash of that commit.

So we can either:

1. Assume that previous commit's subject line was previously validated
and do nothing further; or,
2. Validate the remainder of the commit's subject line as is.

This specific implementation opts for the latter.

Signed-off-by: JP-Ellis <[email protected]>
@epage epage merged commit 50e77c4 into crate-ci:master Dec 18, 2024
17 checks passed
@JP-Ellis JP-Ellis deleted the feat/strip-fixup branch December 19, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for fixup! {conventional}
3 participants