-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QE] update pr check on linux-arm64 #4570
base: main
Are you sure you want to change the base?
Conversation
@lilyLuLiu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lilyLuLiu check the comment in case you wanna apply it
otherwise LGTM
@@ -109,3 +109,23 @@ jobs: | |||
with: | |||
name: gh-context | |||
path: gh_context.json | |||
- name: Check out repository code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May you can upload both version on the same artifact...i.e:
ocp_version
microshift_version
Upload
name: versions
path: *version
just to reduce the code on the download it will automatically put both files there ..so you will reduce code there as welll
otherwise LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianriobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Type of change
test, version modification, documentation, etc.)
Proposed changes
Testing
Contribution Checklist