Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace custom slice Contains method with slices.Contains #4596

Merged

Conversation

rohanKanojia
Copy link
Contributor

Description

Replaced the custom implementation of the slice Contains method with built-in slices.Contains function from the Go standard library.

This simplifies the code and improves readability and maintainability.

Relates to: PR #4591 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

  • Remove crcstrings.Contains method from crcstrings package
  • Use slices.Contains function from the Go standard library in removed method's place.

Testing

I've just verified that project is building and all tests are passing.

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

Replaced the custom implementation of the slice Contains method with
built-in `slices.Contains` function from the Go standard library.

This simplifies the code and improves readability and maintainability.

Signed-off-by: Rohan Kumar <[email protected]>
Copy link
Contributor

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This even catches some situation where Contains was reimplemented manually, nice!

Copy link

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 4, 2025
Copy link

openshift-ci bot commented Feb 4, 2025

@rohanKanojia: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a8b03c7 link false /test security
ci/prow/e2e-crc a8b03c7 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit c7a7434 into crc-org:main Feb 5, 2025
29 of 36 checks passed
@rohanKanojia rohanKanojia deleted the pr/cleanup-contains-slice branch February 5, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants