Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: convert Deeds pop-ups to footnotes and improve HTML5 compatibility #400

Merged
merged 19 commits into from
Dec 1, 2023

Conversation

TimidRobot
Copy link
Member

@TimidRobot TimidRobot commented Nov 30, 2023

Fixes

Fixes #375, fixes #391

Description

App: convert Deeds pop-ups to footnotes and improve HTML5 compatibility

  • add Footnote text and translations from legacy cc-archive/cc.engine/cc-archive/cc.i18n
  • update Deed links so end-users experience fewer redirects
  • configure custom BeautifulSoup HTMLFormatter (html5ish) for improved HTML5 compatibility without impacting translations
  • add single-use shell script that was used to update translation template strings and all impacted translations (also extracts anchor string translation):
  • update format_pofile management command to accept wrap width option so strings in .po portable object Gettext Files could be temporarily limited to a single line for easier matching/replacement

Also see related Data PRs:

Technical details

Tests

Name    Stmts   Miss Branch BrPart    Cover   Missing
-----------------------------------------------------
TOTAL    1662      0    566      0  100.00%

20 files skipped due to complete coverage.

Screenshots

See related Data PR:

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link
Member

@Shafiya-Heena Shafiya-Heena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my best knowledge, it seems good to me. Thank you!

@TimidRobot TimidRobot merged commit e3670db into main Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants