Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA attribute added to website for accessibility #336

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ARIA attribute added to website for accessibility #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb1680b
ARIA attribute added to website for accessibility
SisiVero Oct 11, 2024
1770329
aria attributes set within the content area of the cc-resource-archiv…
SisiVero Oct 15, 2024
bc2156a
aria and added space removed from footer and header
SisiVero Oct 15, 2024
be86b46
aria features that duplicate texts have been removed.
SisiVero Nov 20, 2024
d3aa5a3
unwanted changes removed in listing.html
SisiVero Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions docs/_layouts/listing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,10 @@ <h1>Resources</h1>
class="thumbnailbox {{ page.topic }} {{ page.medium }} {{page.language}}"
>
<article>
<img class="thumbnail" src="{{page.image-thumb}}" alt="{% if
<img
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be related to ARIA?

class="thumbnail"
src="{{page.image-thumb}}"
alt="{% if
page.image-alt %}{{ page.image-alt }} {% else %} '' {% endif %} "
/>
<h3 class="thumbnailtitle">
Expand All @@ -95,7 +98,10 @@ <h3 class="thumbnailtitle">
class="thumbnailbox {{ page.topic }} {{ page.medium }} {{page.language}}"
>
<article>
<img class="thumbnail" src="{{page.image-thumb}}" alt="{% if
<img
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be related to ARIA?

class="thumbnail"
src="{{page.image-thumb}}"
alt="{% if
page.image-alt %}{{ page.image-alt }} {% else %} '' {% endif %} "
/>
<h3 class="thumbnailtitle">
Expand Down
4 changes: 2 additions & 2 deletions docs/_layouts/resource.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,11 @@ <h1>{{page.title}}</h1>
<a
rel="license"
href="http://creativecommons.org/licenses/{{ page.license | remove: 'CC ' | downcase | replace: ' ', '/' }}/"
>
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unrelated to PR, please remove.

<img
alt="Creative Commons License"
src="http://i.creativecommons.org/l/{{ page.license | remove: 'CC ' | downcase | replace: ' ', '/' }}/88x31.png"
/>
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sees unrelated to PR, please remove.

</a>
<p>
{% if page.downloadurl %}
Expand Down
2 changes: 1 addition & 1 deletion docs/_pages/all.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<!-- This is the resourcenavbar, which contains the category filters. The categories are TOPIC, MEDIUM and LANGUAGE. In this there are two different options for displaying a category,
For example - resourcenavtopicknown and resourcenavtopicunknown -->
<!-- If the user has selected a filter, resourcenavtopicknown will be displayed. otherwise resourcenavtopicunknown will be displayed -->
<aside id="resourcenavbar">
<aside id="resourcenavbar" aria-label="Resource Filtering Bar">
<article class="resourcenav resourcenavtopicknown">
<h2>Topic</h2>
<p>
Expand Down