Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon added #8

Closed
wants to merge 1 commit into from
Closed

Conversation

Lakshay-Pruthi
Copy link

@Lakshay-Pruthi Lakshay-Pruthi commented Mar 24, 2023

Fixes

Fixes #6 by @Lakshay-Pruthi

Description

Favicon was not present. Now the favicon is added.
Code indentation of index.html also got fixed by default.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Lakshay-Pruthi Lakshay-Pruthi requested review from a team as code owners March 24, 2023 18:00
@Lakshay-Pruthi Lakshay-Pruthi requested review from TimidRobot, possumbilities, JackieBinya, dhruvkb and Dhruvi16 and removed request for a team March 24, 2023 18:00
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

It is missing:

  • favicon.ico
  • site.webmanifest

@possumbilities
Copy link
Contributor

@Lakshay-Pruthi +1 to the above comment about items missing.

Hi! I really appreciate the enthusiasm here, but I would also kindly acknowledge that the Issue in question is still sitting in "awaiting triage" and if you read through the Contribution Guidelines shouldn't be worked on or have a PR submitted against it yet.

There is a plan to reconsider our current use of app icons and favicon inclusion that hasn't resolved, so I'm leaving this PR open until that's settled.

@Lakshay-Pruthi
Copy link
Author

@possumbilities I apologize for forgetting to check the labels, Not making any changes to the PR till the reconsideration happens.

@possumbilities
Copy link
Contributor

possumbilities commented Feb 20, 2024

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favicon and app icons not present on website
3 participants