Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Vimeo as an additional External Source #131

Closed
1 task done
Rubadel opened this issue Oct 21, 2022 · 2 comments · Fixed by #138
Closed
1 task done

[Feature] Add Vimeo as an additional External Source #131

Rubadel opened this issue Oct 21, 2022 · 2 comments · Fixed by #138
Assignees
@Rubadel @possumbilities
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@Rubadel
Copy link
Contributor

Rubadel commented Oct 21, 2022 •
edited
Loading

Problem

This is a sub-issue out of #48

Description

From the additional sources list in the file get-additional-sources.ts that mentioned in #48, I choose theVimeo which provide more of video options free and paid.

Screen Shot 1444-03-25 at 4 47 54 AM

Additional context

That provide more resource for the Creative Commons engine

Implementation
@Rubadel Rubadel added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 21, 2022
@possumbilities possumbilities added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 21, 2022
@Rubadel Rubadel mentioned this issue Oct 21, 2022
Closed
7 tasks
@possumbilities possumbilities self-assigned this Oct 24, 2022
This was referenced Oct 24, 2022
Closed
Merged
@SilasEze
Copy link

I would be interested in implementing this feature.
Could you assign me @TimidRobot @possumbilities

@possumbilities possumbilities mentioned this issue Oct 26, 2022
Closed
2 tasks
@TimidRobot TimidRobot changed the title [Feature] <Add Vimeo as an additional External Source > [Feature] Add Vimeo as an additional External Source Oct 26, 2022
@possumbilities
Copy link
Contributor

In reference to #160 to fully resolve this Issue the appropriate aria-label will need to be added to the engine button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rubadel Rubadel

@possumbilities possumbilities

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
None yet
Milestone
No milestone
3 participants
@Rubadel @SilasEze @possumbilities