Add vimeo as an additional external source #133
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #131 by @Rubadel, @possumbilities assign me
Description
Add an additional external search source, vimoe for videos
Technical details
I have added all desired implemention code in both search.js and index.php
Tests
1- Define Vimeo in the [engines array] in search.js file.
2- Set it in [ switch case] in [modRights function] in search.js file,
In that I set license , [rights = &license=by for both] for [ if (comm && deriv)] and [(comm && !deriv)] conditions.
3- set it in [switch case] in [doSearch function] with all needed for done the search, in search.js file, as well as I added this in index.php file within the desired place of the implementation.
Screenshots
uncheck commercial use, it without the license
Screen.Recording.1444-03-26.at.1.11.37.AM.mov
check commercial use it with the license
Screen.Recording.1444-03-26.at.1.11.55.AM.mov
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin