Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vimeo as an additional external source #133

Conversation

Rubadel
Copy link
Contributor

@Rubadel Rubadel commented Oct 21, 2022

Fixes

Fixes #131 by @Rubadel, @possumbilities assign me

Description

Add an additional external search source, vimoe for videos

Technical details

I have added all desired implemention code in both search.js and index.php

Tests

1- Define Vimeo in the [engines array] in search.js file.

2- Set it in [ switch case] in [modRights function] in search.js file,
In that I set license , [rights = &license=by for both] for [ if (comm && deriv)] and [(comm && !deriv)] conditions.

3- set it in [switch case] in [doSearch function] with all needed for done the search, in search.js file, as well as I added this in index.php file within the desired place of the implementation.

Screenshots

Screen Shot 1444-03-26 at 1 07 39 AM

uncheck commercial use, it without the license

Screen.Recording.1444-03-26.at.1.11.37.AM.mov

check commercial use it with the license

Screen.Recording.1444-03-26.at.1.11.55.AM.mov

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Rubadel Rubadel requested review from a team and possumbilities and removed request for a team October 21, 2022 22:23
@Rubadel Rubadel force-pushed the Add-Vimeo-as-an-additional-External-Source branch from b500164 to d3941b4 Compare October 21, 2022 22:23
@possumbilities
Copy link
Contributor

Hi @Rubadel very glad you're excited to submit this PR. You've included a number of files not related to this project. I would strongly urge you to make a fresh branch with only the changes needed and submit a fresh PR when you have the time.

Files like the following should not be commited as part of the branch or this PR

  • .DS_Store
  • .vscode
  • started
  • started,
  • done,

@Rubadel Rubadel deleted the Add-Vimeo-as-an-additional-External-Source branch October 24, 2022 22:12
@possumbilities possumbilities self-assigned this Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Vimeo as an additional External Source
2 participants