Skip to content

Commit

Permalink
Add crash reporter cfg which fixes #54
Browse files Browse the repository at this point in the history
  • Loading branch information
cretz committed Oct 2, 2017
1 parent c870baf commit 30c73c6
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 2 deletions.
4 changes: 4 additions & 0 deletions docs/guide/develop.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ Any bugs or enhancement requests can be filed in via [GitHub issues](https://git
filing a bug, please try to be as descriptive as possible on the issue. Ideally, provide a page or set of pages that
trigger the error.

If there is a crash, the crash file will be dumped on the user's computer. This can be found at
`C:\Users\USER_NAME\AppData\Local\Doogie\User Data\Crashpad\reports` on Windows (TODO: where on Linux). Please upload
this file to the issue tracker for bugs about crashes.

If you are a developer, one of the easiest ways to do this is to add the pages to `src/tests/integration/resources`.
Then by running `npm run resource-server` from `src/tests/integration` the resources can be browsed via
http://127.0.0.1:1993 (e.g. [http://127.0.0.1:1993/hello-world.html](http://127.0.0.1:1993/hello-world.html)).
Expand Down
14 changes: 12 additions & 2 deletions src/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,13 @@ func copyResourcesLinux(qmakePath string, target string) error {
return fmt.Errorf("Unable to find CEF_DIR env var")
}
// Everything read only except by owner
// Copy over crash reporter cfg
err := copyAndChmodEachToDirIfNotPresent(0644, ".", target, "crash_reporter.cfg")
if err != nil {
return err
}
// Copy over some Qt DLLs
err := copyAndChmodEachToDirIfNotPresent(0644, filepath.Join(filepath.Dir(qmakePath), "../lib"), target,
err = copyAndChmodEachToDirIfNotPresent(0644, filepath.Join(filepath.Dir(qmakePath), "../lib"), target,
"libQt5Core.so.5",
"libQt5Gui.so.5",
"libQt5Sql.so.5",
Expand Down Expand Up @@ -517,6 +522,11 @@ func copyResourcesWindows(qmakePath string, target string) error {
if cefDir == "" {
return fmt.Errorf("Unable to find CEF_DIR env var")
}
// Copy over crash reporter cfg
err := copyEachToDirIfNotPresent(".", target, "crash_reporter.cfg")
if err != nil {
return err
}
// Copy over some Qt DLLs
qtDlls := []string{
"Qt5Core.dll",
Expand All @@ -536,7 +546,7 @@ func copyResourcesWindows(qmakePath string, target string) error {
qtDlls = append(qtDlls, strings.Replace(dll, ".dll", ".pdb", -1))
}
}
err := copyEachToDirIfNotPresent(filepath.Dir(qmakePath), target, qtDlls...)
err = copyEachToDirIfNotPresent(filepath.Dir(qmakePath), target, qtDlls...)
if err != nil {
return err
}
Expand Down
3 changes: 3 additions & 0 deletions src/crash_reporter.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[Config]
ProductName=doogie
AppName=Doogie

0 comments on commit 30c73c6

Please sign in to comment.