Skip to content

Commit

Permalink
Strip libcef.so lib in release mode
Browse files Browse the repository at this point in the history
  • Loading branch information
cretz committed Sep 7, 2017
1 parent 57be684 commit 730d677
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,19 @@ func buildCefLinux() error {
filepath.Join(wrapperDir, "libcef_dll_wrapper_"+target+".a")); err != nil {
return fmt.Errorf("Unable to rename .a file: %v", err)
}
// We also need to run strip on the Release libcef.so per:
// https://bitbucket.org/chromiumembedded/cef/issues/1979
if target == "Release" {
// Back it up first
err := copyIfNotPresent(filepath.Join(cefDir, "Release/libcef.so"),
filepath.Join(cefDir, "Release/libcef.fullsym.so"))
if err != nil {
return fmt.Errorf("Release libcef backup failed: %v", err)
}
if err = execCmdInDir(cefDir, "strip", "--strip-all", "Release/libcef.so"); err != nil {
return fmt.Errorf("Failed stripping symbols: %v", err)
}
}
return nil
}

Expand Down

0 comments on commit 730d677

Please sign in to comment.