Workflow: fix golangci-lint version

Also fix all linter issues

.github/workflows/golangci-lint.yml

@@ -20,4 +20,4 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v6.2.0
+          version: v1.63.4

config.go

@@ -3,7 +3,6 @@ package main
 import (
 	"flag"
 	"fmt"
-	"io/ioutil"
 	"log"
 	"os"
 
@@ -63,7 +62,7 @@ func GetConfig() Config {
 	cfg.Memory = memory.DefaultConfig
 
 	if *configFileFlag != "" {
-		f, err := ioutil.ReadFile(*configFileFlag)
+		f, err := os.ReadFile(*configFileFlag)
 		if err != nil {
 			log.Fatal(err)
 		}

server/server.go

@@ -73,11 +73,21 @@ func (s *Server) Serve() error {
 			return
 		}
 
-		json.NewEncoder(w).Encode(events)
+		err = json.NewEncoder(w).Encode(events)
+		if err != nil {
+			log.Errorf("encoding error %s", err)
+			http.Error(w, err.Error(), 500)
+			return
+		}
 	})
 
 	s.router.GET("/filter-entries", func(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
-		json.NewEncoder(w).Encode(s.services.FilterEntries())
+		err := json.NewEncoder(w).Encode(s.services.FilterEntries())
+		if err != nil {
+			log.Errorf("encoding error %s", err)
+			http.Error(w, err.Error(), 500)
+			return
+		}
 	})
 
 	s.router.GET("/ws", func(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
@@ -97,7 +107,12 @@ func (s *Server) Serve() error {
 	})
 
 	s.router.GET("/status", func(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
-		w.Write([]byte("OK"))
+		_, err := w.Write([]byte("OK"))
+		if err != nil {
+			log.Errorf("/status error %s", err)
+			http.Error(w, err.Error(), 500)
+			return
+		}
 	})
 
 	s.router.GET("/metrics", func(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {

storage/distributed.go

@@ -76,7 +76,10 @@ func (s *Distributed) lockLoop() {
 		case <-s.stop:
 			atomic.StoreUint32(&s.enabled, 0)
 			log.Info("unlocking storage lock")
-			lock.Unlock()
+			err := lock.Unlock()
+			if err != nil {
+				log.Error(err)
+			}
 			s.done.Done()
 			return
 		}

storage/memory/storage.go

@@ -8,8 +8,6 @@ import (
 )
 
 type Storage struct {
-	cfg Config
-
 	events []tl.Event
 	next   int
 	size   int

storage/memory/storage_test.go

@@ -11,10 +11,10 @@ func TestWrap(t *testing.T) {
 
 	s := New(Config{MaxSize: 3})
 
-	s.Store(tl.Event{ID: 1})
-	s.Store(tl.Event{ID: 2})
-	s.Store(tl.Event{ID: 3})
-	s.Store(tl.Event{ID: 4})
+	_ = s.Store(tl.Event{ID: 1})
+	_ = s.Store(tl.Event{ID: 2})
+	_ = s.Store(tl.Event{ID: 3})
+	_ = s.Store(tl.Event{ID: 4})
 
 	require.Equal(t,
 		[]tl.Event{

timeline/event.go

@@ -38,7 +38,7 @@ type Event struct {
 	ID int32 `json:"-"`
 
 	Time       time.Time `json:"time,omitempty"`
-	Datacenter string    `json:"datacenter,omuitempty"`
+	Datacenter string    `json:"datacenter,omitempty"`
 
 	NodeName      string `json:"node_name,omitempty"`
 	NodeIP        string `json:"node_ip,omitempty"`