Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): made sure self links at document level use service-url-provider as base url #815

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

vicmosin
Copy link
Contributor

@vicmosin vicmosin commented May 27, 2021

Resolves #789

@vicmosin
Copy link
Contributor Author

@remmeier
made my version of #793

  1. I saw you comment about wrong place for calculating the proper URL and imo the place you suggested is also isn't perfect. I find HttpRequestContextBaseAdapter to be bound to current HTTP request, therefor it would be confusing to put there ServiceUrlProvider-related URLs. QueryContext, on the other hand, fits perfectly as it holds not only HTTP stuff but crnk context about current query, so I extended it.
  2. I could not find a good place for integration test so used spring-boot-example project to have the new test which checks the links without any additional mocking

@remmeier
Copy link
Contributor

remmeier commented Jun 3, 2021

thx!

@remmeier remmeier merged commit 1e33a2f into crnk-project:master Jun 3, 2021
@datagitlies
Copy link
Contributor

is there an ETA for a new release with this fix @remmeier ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated selfs links on top level does not respect ServiceUrlProvider
3 participants