Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a defaut while miss cache provider #115

Merged
merged 11 commits into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions src/defaultWhileMiss.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import {CacheLoader, CacheProvider} from './cacheProvider';

type Configuration<K, V> = {
cacheProvider: CacheProvider<K, V>,
timeout: number,
defaultValue: V,

marcospassos marked this conversation as resolved.
Show resolved Hide resolved
/**
* Handler for background revalidation errors
*/
errorHandler?: (error: Error) => void,
};

export class DefaultWhileMissCache<K, V> implements CacheProvider<K, V> {
private readonly cacheProvider: Configuration<K, V>['cacheProvider'];
renan628 marked this conversation as resolved.
Show resolved Hide resolved

private readonly timeout: number;

private readonly defaultValue: V;

private readonly errorHandler: (error: Error) => void;

public constructor(config: Configuration<K, V>) {
this.cacheProvider = config.cacheProvider;
this.timeout = config.timeout;
this.defaultValue = config.defaultValue;
this.errorHandler = config.errorHandler ?? ((): void => { /* noop */ });
}

public get(key: K, loader: CacheLoader<K, V>): Promise<V> {
const resolveWithTimeout = (value: V): Promise<V> => new Promise(resolve => {
setTimeout(() => resolve(value), this.timeout);
});
renan628 marked this conversation as resolved.
Show resolved Hide resolved

return Promise.race([
resolveWithTimeout(this.defaultValue),
this.cacheProvider
.get(key, loader)
.catch(error => {
this.errorHandler(error);

return this.defaultValue;
}),
]);
}

public set(key: K, value: V): Promise<void> {
return this.cacheProvider.set(key, value);
}

public delete(key: K): Promise<void> {
return this.cacheProvider.delete(key);
}
}
123 changes: 123 additions & 0 deletions test/defaultWhileMiss.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
import {extractErrorMessage, InMemoryLogger, LogLevel} from '@croct/logging';
import {NoopCache} from '../src';
import {DefaultWhileMissCache} from '../src/defaultWhileMiss';

describe('A cache provider that returns a default value if a timeout occurs', () => {
it('should return the inner cache value when it returns before the timeout', async () => {
const inner = new NoopCache();

jest.spyOn(inner, 'get');

const loader = (): Promise<string> => Promise.resolve('loaderValue');

const cache = new DefaultWhileMissCache({
timeout: 10,
cacheProvider: inner,
defaultValue: 'defaultValue',
});

await expect(cache.get('key', loader)).resolves.toBe('loaderValue');

expect(inner.get).toHaveBeenCalledWith('key', expect.any(Function));
});

it('should return the default value when the inner cache returns after the timeout', async () => {
const inner = new NoopCache();

jest.spyOn(inner, 'get');

const loader = (): Promise<string> => new Promise(resolve => {
setTimeout(() => resolve('loaderValue'), 10);
});

const cache = new DefaultWhileMissCache({
timeout: 0,
cacheProvider: inner,
defaultValue: 'defaultValue',
});

await expect(cache.get('key', loader)).resolves.toBe('defaultValue');

expect(inner.get).toHaveBeenCalledWith('key', expect.any(Function));
});

it('should return the default value when the inner cache rejects', async () => {
const inner = new NoopCache();

jest.spyOn(inner, 'get');

const loader = (): Promise<unknown> => Promise.reject(new Error('Some error'));

const cache = new DefaultWhileMissCache({
timeout: 10,
cacheProvider: inner,
defaultValue: 'defaultValue',
});

await expect(cache.get('key', loader)).resolves.toBe('defaultValue');

expect(inner.get).toHaveBeenCalledWith('key', expect.any(Function));
});

it('should return the default value using a custom error handler when the inner cache rejects', async () => {
const inner = new NoopCache();
const logger = new InMemoryLogger();

jest.spyOn(inner, 'get');

const loader = (): Promise<unknown> => Promise.reject(new Error('Some error'));

const errorHandler = (error: Error): void => logger.log({
message: extractErrorMessage(error),
level: LogLevel.ERROR,
});
renan628 marked this conversation as resolved.
Show resolved Hide resolved

const cache = new DefaultWhileMissCache({
timeout: 10,
cacheProvider: inner,
defaultValue: 'defaultValue',
errorHandler: errorHandler,
});

await expect(cache.get('key', loader)).resolves.toBe('defaultValue');

expect(inner.get).toHaveBeenCalledWith('key', expect.any(Function));

expect(logger.getLogs()).toStrictEqual([{
message: 'Some error',
level: LogLevel.ERROR,
}]);
});

it('should forward the setting of values', async () => {
renan628 marked this conversation as resolved.
Show resolved Hide resolved
const inner = new NoopCache();
renan628 marked this conversation as resolved.
Show resolved Hide resolved

jest.spyOn(inner, 'set');

const cache = new DefaultWhileMissCache({
timeout: 10,
cacheProvider: inner,
defaultValue: 'defaultValue',
});

await cache.set('key', 'value');

expect(inner.set).toHaveBeenCalledWith('key', 'value');
});

it('should forward deletions', async () => {
const inner = new NoopCache();
renan628 marked this conversation as resolved.
Show resolved Hide resolved

jest.spyOn(inner, 'delete');

const cache = new DefaultWhileMissCache({
timeout: 10,
cacheProvider: inner,
defaultValue: 'defaultValue',
});

await cache.delete('key');

expect(inner.delete).toHaveBeenCalledWith('key');
});
});