Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global node index #38

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Add global node index #38

merged 1 commit into from
Sep 26, 2024

Conversation

marcospassos
Copy link
Member

Summary

Rendering JSX requires a key, which the developer must handle. To make it easier, this PR adds a new index property with a globally unique index for a given parsing.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
marcospassos Marcos Passos
@marcospassos marcospassos added the feature New feature label Sep 26, 2024
@marcospassos marcospassos requested a review from a team as a code owner September 26, 2024 18:41
Copy link

👋 @marcospassos
Thanks for your contribution!
The approval and merge process is almost fully automated 🧙
Here's how it works:

  1. You open a new pull request
  2. Automated tests check the code
  3. Maintainers review the code
  4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.
Happy coding! 🎉

@marcospassos marcospassos changed the title Add global node index to make it easier to render JSX Add global node index Sep 26, 2024
@marcospassos marcospassos enabled auto-merge (squash) September 26, 2024 18:42
@marcospassos marcospassos enabled auto-merge (squash) September 26, 2024 18:43
@marcospassos marcospassos merged commit c4cd4a8 into master Sep 26, 2024
8 of 9 checks passed
@marcospassos marcospassos deleted the node-index branch September 26, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant