Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Readd empty initializers after runtime update #1942

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/controller/ec2/address/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ func SetupAddress(mgr ctrl.Manager, o controller.Options) error {
managed.WithCreationGracePeriod(3 * time.Minute),
managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
managed.WithConnectionPublishers(),
managed.WithInitializers(),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/ec2/instance/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ func SetupInstance(mgr ctrl.Manager, o controller.Options) error {
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), newClientFn: ec2.NewInstanceClient}),
managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
managed.WithConnectionPublishers(),
managed.WithInitializers(),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/ec2/subnet/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ func SetupSubnet(mgr ctrl.Manager, o controller.Options) error {
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), newClientFn: ec2.NewSubnetClient}),
managed.WithCreationGracePeriod(3 * time.Minute),
managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
managed.WithInitializers(),
managed.WithConnectionPublishers(),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/ec2/volume/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ func SetupVolume(mgr ctrl.Manager, o controller.Options) error {
}

reconcilerOpts := []managed.ReconcilerOption{
managed.WithInitializers(),
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/ec2/vpc/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ func SetupVPC(mgr ctrl.Manager, o controller.Options) error {
managed.WithCreationGracePeriod(3 * time.Minute),
managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
managed.WithConnectionPublishers(),
managed.WithInitializers(),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/ec2/vpcendpoint/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ func SetupVPCEndpoint(mgr ctrl.Manager, o controller.Options) error {
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithInitializers(),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
managed.WithConnectionPublishers(cps...),
}
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/eks/addon/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ func SetupAddon(mgr ctrl.Manager, o controller.Options) error {

reconcilerOpts := []managed.ReconcilerOption{
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithInitializers(),
managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/elbv2/target/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ func SetupTarget(mgr ctrl.Manager, o controller.Options) error {

reconcilerOpts := []managed.ReconcilerOption{
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), newClientFn: awselasticloadbalancingv2.NewFromConfig}),
managed.WithInitializers(),
managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
Expand Down
3 changes: 1 addition & 2 deletions pkg/controller/firehose/deliverystream/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ func SetupDeliveryStream(mgr ctrl.Manager, o controller.Options) error {
reconcilerOpts := []managed.ReconcilerOption{
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
managed.WithInitializers(
managed.NewNameAsExternalName(mgr.GetClient())),
managed.WithInitializers(managed.NewNameAsExternalName(mgr.GetClient())),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/globalaccelerator/endpointgroup/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func SetupEndpointGroup(mgr ctrl.Manager, o controller.Options) error {
Complete(managed.NewReconciler(mgr,
resource.ManagedKind(svcapitypes.EndpointGroupGroupVersionKind),
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithInitializers(),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down
3 changes: 1 addition & 2 deletions pkg/controller/kinesis/stream/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ func SetupStream(mgr ctrl.Manager, o controller.Options) error {
reconcilerOpts := []managed.ReconcilerOption{
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithReferenceResolver(managed.NewAPISimpleReferenceResolver(mgr.GetClient())),
managed.WithInitializers(
managed.NewNameAsExternalName(mgr.GetClient())),
managed.WithInitializers(managed.NewNameAsExternalName(mgr.GetClient())),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/mq/broker/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ func SetupBroker(mgr ctrl.Manager, o controller.Options) error {
}

reconcilerOpts := []managed.ReconcilerOption{
managed.WithInitializers(),
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/mq/user/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ func SetupUser(mgr ctrl.Manager, o controller.Options) error {
}

reconcilerOpts := []managed.ReconcilerOption{
managed.WithInitializers(),
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ func SetupAlertManagerDefinition(mgr ctrl.Manager, o controller.Options) error {

reconcilerOpts := []managed.ReconcilerOption{
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithInitializers(),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ func SetupRuleGroupsNamespace(mgr ctrl.Manager, o controller.Options) error {

reconcilerOpts := []managed.ReconcilerOption{
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithInitializers(),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/prometheusservice/workspace/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ func SetupWorkspace(mgr ctrl.Manager, o controller.Options) error {

reconcilerOpts := []managed.ReconcilerOption{
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithInitializers(),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
managed.WithRecorder(event.NewAPIRecorder(mgr.GetEventRecorderFor(name))),
Expand Down
1 change: 1 addition & 0 deletions pkg/controller/ram/resourceshare/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func SetupResourceShare(mgr ctrl.Manager, o controller.Options) error {
}

reconcilerOpts := []managed.ReconcilerOption{
managed.WithInitializers(),
managed.WithExternalConnecter(&connector{kube: mgr.GetClient(), opts: opts}),
managed.WithPollInterval(o.PollInterval),
managed.WithLogger(o.Logger.WithValues("controller", name)),
Expand Down
Loading