Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rdsinstance.database): do not send empty modify-calls #2146

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Jan 22, 2025

Description of your changes

for RDSInstance.database:

  • do not request Modify, when ModifyDBInstanceInput only includes DBInstanceIdentifier and the Modify-Flags(AllowMajorVersionUpgrade, ApplyImmediately)

When user only changed Tags, this could lead to getting the MR stuck, if ApplyImmediately: false was set.
AWS then blocks the request and the whole update-fails:

"update failed: cannot modify RDS instance: api error InvalidParameterCombination: No modifications were requested"

This rarely happened, due to AWS curiously not rejecting empty Modify-Calls with ApplyImmediately: true.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

manually

@wotolom wotolom force-pushed the database-rdsinstance-do-not-send-empty-modify-calls branch 2 times, most recently from 73c165a to 3be4e04 Compare January 22, 2025 15:54
Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <[email protected]>
@wotolom wotolom force-pushed the database-rdsinstance-do-not-send-empty-modify-calls branch from 3be4e04 to 9f9c44a Compare January 22, 2025 16:05
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @wotolom!

@MisterMX MisterMX merged commit cd36a35 into crossplane-contrib:master Jan 22, 2025
8 of 9 checks passed
Copy link

Successfully created backport PR #2148 for release-0.51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants