fix(rdsinstance.database): do not send empty modify-calls #2146
+24
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
for RDSInstance.database:
DBInstanceIdentifier
and the Modify-Flags(AllowMajorVersionUpgrade
,ApplyImmediately
)When user only changed Tags, this could lead to getting the MR stuck, if
ApplyImmediately: false
was set.AWS then blocks the request and the whole update-fails:
This rarely happened, due to AWS curiously not rejecting empty Modify-Calls with
ApplyImmediately: true
.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
manually