fix(rdsinstance.database): do not overwrite engineVersion if only major was set + add engineVersion to observe #2149
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or was set + add engineVersion to observe Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <[email protected]>
|
Successfully created backport PR #2150 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
for
RDSInstance.database:engineVersionwhen only major is setengineVersionin detail (considering major and minor)engineVersionin AWS.status.atProvider.engineVersionFixes:
for setups where MRs were applied automatically (e.g. via Composition/XR) the
spec.forProvider.engineVersionwould constantly flicker due to this lateinit part, when user set only the major version (which is valid by AWS; and makes sense in combination withautoMinorVersionUpgrade)I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
manually