fix(ec2): fix ipv6 field issues in ec2 group

[haarchri]

Signed-off-by: Christopher Paul Haar [email protected]

Description of your changes

we tested today upbound/provider-aws and found 2 issues regarding ipv6 fields in aws_instance and aws_network_interface - looks like this issue has open PRs in crossplane-contrib/provider-jet-aws as well

    message: |-
      observe failed: cannot run refresh: refresh failed: Conflicting configuration arguments: "ipv6_addresses": conflicts with ipv6_address_count: File name: main.tf.json
      Conflicting configuration arguments: "ipv6_address_count": conflicts with ipv6_addresses: File name: main.tf.json

crossplane-contrib/provider-jet-aws#227
crossplane-contrib/provider-jet-aws#228

Fixes #

I have:

• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

apply instance with network interface

[Upbound-CLA]

All committers have signed the CLA.

[haarchri]

/test-examples="examples/ec2/instance.yaml,examples/ec2/networkinterface.yaml"

[muvaf]

/test-examples="examples/ec2/instance.yaml,examples/ec2/networkinterface.yaml"

[muvaf]

@haarchri Do you see Uptest passing in your local?

[turkenh]

/test-examples="examples/ec2/instance.yaml"

[turkenh]

/test-examples="examples/ec2/networkinterface.yaml"

[turkenh]

Rebased this PR on the latest main and triggered tests individually 🤞

[jeanduplessis]

/test-examples="examples/ec2/instance.yaml"

[jeanduplessis]

/test-examples="examples/ec2/networkinterface.yaml"

[jeanduplessis]

@haarchri would you mind signing the CLA?

[turkenf]

Required status checks have been changed, could you please rebase this PR?

[sergenyalcin]

@haarchri Could you please rebase this PR? And also for a successful uptest, could you please fix the example manifest of this resource by adding a subnet reference? Thank you :)

[haarchri]

@sergenyalcin yes i will do this

[haarchri]

update the examples:

kubectl get managed
NAME                                        READY   SYNCED   EXTERNAL-NAME              AGE
subnet.ec2.aws.upbound.io/sample-instance   True    True     subnet-09f2b96d10f79e341   5m52s

NAME                                     READY   SYNCED   EXTERNAL-NAME           AGE
vpc.ec2.aws.upbound.io/sample-instance   True    True     vpc-038239817b67cb1e1   5m52s

NAME                                          READY   SYNCED   EXTERNAL-NAME         AGE
instance.ec2.aws.upbound.io/sample-instance   True    True     i-07528490a2525cac9   5m52s

NAME                                                  READY   SYNCED   EXTERNAL-NAME           AGE
networkinterface.ec2.aws.upbound.io/sample-instance   True    True     eni-01c038e72d4a7fcc2   5m52s

[haarchri]

/test-examples="examples/ec2/instance.yaml"

[haarchri]

@sergenyalcin @jeanduplessis done ! test is green - please check again - sorry for late answer

[haarchri]

/test-examples="examples/ec2/instance.yaml"

[ytsarev]

Suggested change

	"interface_type", "private_ip_list", "private_ips", "ipv6_address_count",
	"interface_type", "private_ip_list", "private_ips", ipv6_addresses, "ipv6_address_count",

I think we usually include both conflicting fields in the IgnoredFields slice.

@ulucinar @sergenyalcin please keep me honest here.

[ulucinar]

Yes, agreed. When the native schema declares two configuration arguments as mutually exclusive, we need to ignore them both during late-initialization because we may have set either of them under spec.forProvider and the unset one could be late-initialized at runtime causing a conflict. The argument ipv6_addresses is declared to conflict with the ipv6_address_count and similarly, ipv6_address_count is declared to conflict with with ipv6_addresses.

In this specific case, the relationship is mutual, i.e., ipv6_addresses & ipv6_address_count are mutually exclusive as dictated in the native (Terraform) schema. In theory, this may not always be true (consider a case in which if argument a is set then b gets initialized from a but the reverse is not true, i.e., if b is set, a does not get initialized). I don't know any practical examples of this and I think we had better assume a mutual relationship for late-initialization.

[turkenf]

Included ipv6_addresses to IgnoredFields.

[turkenf]

/test-examples="examples/ec2/instance.yaml"

[turkenf]

Verified with uptest run.