Merge branch 'master' into releases/1.6.x

crowdsecurity · Feb 10, 2025 · 72b4354 · 72b4354
2 parents cd98b70 + c5e0003
commit 72b4354
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/pkg/cwhub/hub.go b/pkg/cwhub/hub.go
@@ -165,7 +165,9 @@ func (h *Hub) Update(ctx context.Context, indexProvider IndexProvider, withConte
 	}
 
 	if !downloaded {
-		fmt.Println("Nothing to do, the hub index is up to date.")
+		// use logger and the message will be silenced in the cron job
+		// (no mail if nothing happened)
+		h.logger.Info("Nothing to do, the hub index is up to date.")
 	}
 
 	return nil

diff --git a/test/bats/20_hub.bats b/test/bats/20_hub.bats
@@ -109,7 +109,8 @@ teardown() {
     rune -0 cscli hub update
     assert_output "Downloading $INDEX_PATH"
     rune -0 cscli hub update
-    assert_output "Nothing to do, the hub index is up to date."
+    refute_output
+    assert_stderr 'level=info msg="Nothing to do, the hub index is up to date."'
 }
 
 @test "cscli hub upgrade (up to date)" {