Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli: remove "dashboard" command #3004

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

cscli: remove "dashboard" command #3004

wants to merge 15 commits into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 13, 2024

#2927

How do we handle this?

debian/prerm
2: cscli dashboard remove -f -y --error || echo "Ignore the above error if you never installed the local dashboard."

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.21%. Comparing base (9ef5f58) to head (2dff39b).

Files with missing lines Patch % Lines
cmd/crowdsec-cli/dashboard.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
+ Coverage   59.11%   60.21%   +1.10%     
==========================================
  Files         359      355       -4     
  Lines       38730    37906     -824     
==========================================
- Hits        22894    22826      -68     
+ Misses      13908    13160     -748     
+ Partials     1928     1920       -8     
Flag Coverage Δ
bats 42.97% <62.50%> (+0.76%) ⬆️
unit-linux 33.61% <0.00%> (+0.81%) ⬆️
unit-windows 28.55% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the remove-dashboard branch from baf570d to 89874ad Compare May 21, 2024 07:42
@mmetc mmetc force-pushed the remove-dashboard branch 2 times, most recently from 1541c5a to 6ab7f4d Compare June 3, 2024 07:01
@mmetc mmetc force-pushed the remove-dashboard branch 6 times, most recently from beea707 to 8e65eb2 Compare June 12, 2024 06:24
@mmetc mmetc force-pushed the remove-dashboard branch from 8e65eb2 to 10b82f0 Compare June 20, 2024 08:41
@mmetc mmetc force-pushed the remove-dashboard branch from 10b82f0 to 08958d6 Compare July 31, 2024 12:25
@mmetc mmetc added this to the 1.7.0 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants