Allow "Speed up" on transactions with a single output #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-desktop-docs canceled.
|
|
Do not hesitate to close this PR if you would rather have a complete fix for the whole issue. It's just that this is the second time I've needed this feature and since I have working code for it, I thought I'd share it in case you or anyone else wants it. |
|
Thanks for your contribution and sorry for the delay. Very much appreciated! |
stepansnigirev
approved these changes
May 2, 2024
|
This is now reelased: https://github.com/cryptoadvance/specter-desktop/releases/tag/v2.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the fee bump feature on single-output transactions by reducing the output amount. Without it Specter complains that it can't bump fee in a transaction without change outputs.
This is meant to partially resolve #988. This issue is marked as resolved, but it's not because of #2377 (which seems to be much more complex to solve than what this PR does).
Multiple-output transactions without change are still not supported.
And there's no UI to warn you that the output amount is being reduced. I'm not sure that's necessary.