Jonas/refactor tables #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the state here? |
|
The demo can be built now, since I pinned $ cd ./hacspec-scrambledb/scrambledb
$ CC=emcc AR=emar wasm-pack build --target web --features wasmbuilds the demo in |
franziskuskiefer
requested changes
Nov 6, 2023
- remove commented code - Rename according to spec - Consistent documentation
… jonas/refactor-tables
|
With the latest commit, I've removed the old comments, aligned the transformation names with the naming scheme from the spec and given more consistent doc comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR greatly simplifies table data structures and thereby table transformations.
It's still a draft for now since the WASM demo needs more help. It's updated to use the new table types but the
wasmfeature does not build at the moment, I believe because of the dependency onlibcrux, although I tried enablinglibcrux'es ownwasmfeature, to no avail.