Merge branch 'ml-dsa-lax' into jonas/ml-dsa-target-feature

cryspen · Nov 5, 2024 · 5c005e0 · 5c005e0
2 parents 61f72fd + 7297c0b
commit 5c005e0
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/libcrux-ml-dsa/src/samplex4.rs b/libcrux-ml-dsa/src/samplex4.rs
@@ -10,6 +10,10 @@ fn generate_domain_separator(row: u8, column: u8) -> u16 {
     (column as u16) | ((row as u16) << 8)
 }
 
+// Doing deep updates like `a[1][1] = 3` causes a memory blowup in F*
+// https://github.com/hacspec/hax/issues/1098
+// So we are instead using a matrix abstraction with a custom update function here.
+
 type Matrix<SIMDUnit, const ROWS_IN_A: usize, const COLUMNS_IN_A: usize> =
     [[PolynomialRingElement<SIMDUnit>; COLUMNS_IN_A]; ROWS_IN_A];