ML-DSA: AVX2 implementations of some arithmetic functions and t1 deserialization. #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvzcf
requested review from
franziskuskiefer,
karthikbhargavan and
jschneider-bensch
jschneider-bensch
approved these changes
Jul 31, 2024
|
|
||
| // We will test if |simd_unit| > bound - 1, because if this is the case then | ||
| // it follows that |simd_unit| >= bound | ||
| let bound = mm256_set1_epi32(bound - 1); |
There was a problem hiding this comment.
In theory this could underflow, right? Is that why you want to revisit?
There was a problem hiding this comment.
Ah, I'm not sure if it can underflow, but I put the TODO there since I haven't tried to properly calculate the representative ranges that this function will see.
Co-authored-by: Jonas Schneider-Bensch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.