Leverage latest code quality improvements in Eurydice etc. #472
Conversation
|
I thought I had modified the Docker file to pick up the latest versions of tooling but apparently not. |
You have, but it's not automated (see #417). |
|
|
||
| The NIST FIPS 203 standard can be found at | ||
| <https://csrc.nist.gov/pubs/fips/203/ipd>. | ||
| */ |
There was a problem hiding this comment.
Hm, we get two comments here? Can they be merged?
There was a problem hiding this comment.
Would you like them merged? It's a matter of preference whether you want the user-written comment fused with the auto-generated one. I don't have a strong opinion, except that visually it helps I think to separate the two.
| @@ -2534,11 +2613,10 @@ with const generics | |||
| static inline libcrux_ml_kem_polynomial_PolynomialRingElement_d2 clone_d5_48( | |||
| libcrux_ml_kem_polynomial_PolynomialRingElement_d2 *self) { | |||
| libcrux_ml_kem_polynomial_PolynomialRingElement_d2 lit; | |||
| core_core_arch_x86___m256i ret[16U]; | |||
| __m256i ret[16U]; | |||
There was a problem hiding this comment.
Could this collide with the real __m256i type?
There was a problem hiding this comment.
right but there is a typedef anyhow https://github.com/cryspen/libcrux/blob/main/libcrux-ml-kem/c/intrinsics/libcrux_intrinsics_avx2.h#L20 so that's cool
|
|
||
| ```plaintext | ||
| Input: byte stream B ∈ 𝔹*. | ||
| Output: array â ∈ ℤ₂₅₆. |
There was a problem hiding this comment.
I hope C tools are ok with all the unicode characters 😬
|
I'm also pushing a couple other low-hanging fruits on this branch, such as chopping the libcrux_intrinsics prefix for intrinsics. |
…acros in eurydice_glue.h
|
In order to make the C code not blow up the stack I
|
No description provided.