Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACVP test vectors for ML-KEM #618

Merged
merged 5 commits into from
Oct 8, 2024
Merged

ACVP test vectors for ML-KEM #618

merged 5 commits into from
Oct 8, 2024

Conversation

jschneider-bensch
Copy link
Collaborator

@jschneider-bensch jschneider-bensch commented Oct 7, 2024

I've taken up Franziskus' branch that did KeyGen testing with the ACVP vectors and extended it to run the Encaps/Decaps tests as well.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm with two small nits.

libcrux-ml-kem/tests/acvp.rs Outdated Show resolved Hide resolved
libcrux-ml-kem/tests/acvp.rs Outdated Show resolved Hide resolved
libcrux-ml-kem/tests/acvp.rs Outdated Show resolved Hide resolved
@jschneider-bensch jschneider-bensch added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 897008e Oct 8, 2024
48 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/ml-kem-acvp branch October 8, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants