Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML-KEM] serialize sk #623

Merged
merged 19 commits into from
Nov 13, 2024
Merged

[ML-KEM] serialize sk #623

merged 19 commits into from
Nov 13, 2024

Conversation

franziskuskiefer
Copy link
Member

For the unpacked APIs BoringSSL wants to generate the key pair from the serialised private key. That's what this PR does.

Note that the C extraction depends on FStarLang/karamel#491 and AeneasVerif/eurydice#80.

Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. I would love to get the secret independence checking working on this code soon (since we are parsing and validating secret data).

@franziskuskiefer franziskuskiefer added this pull request to the merge queue Nov 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 13, 2024
@karthikbhargavan karthikbhargavan added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 9b4b799 Nov 13, 2024
52 checks passed
@karthikbhargavan karthikbhargavan deleted the franziskus/mlkem-serialize-sk branch November 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants