Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First changes for ML-DSA C extraction #707

Merged
merged 5 commits into from
Dec 10, 2024
Merged

First changes for ML-DSA C extraction #707

merged 5 commits into from
Dec 10, 2024

Conversation

franziskuskiefer
Copy link
Member

First steps towards extracting C code for ML-DSA.

  • ML-DSA key size feature gates
  • C extraction infrastructure
  • Moved Signature type
  • Moved to named struct for types

cc #706

@franziskuskiefer
First changes for ML-DSA C extraction
d972def 
- ML-DSA key size feature gates
- C extraction infrastructure
- Moved Signature type
- Moved to named struct for types
@franziskuskiefer
udpate hax extraction
ebd9959
@franziskuskiefer franziskuskiefer self-assigned this Dec 3, 2024
@franziskuskiefer franziskuskiefer requested a review from a team as a code owner December 3, 2024 20:07
This was referenced Dec 6, 2024
Closed
Merged
keks
keks previously requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I focussed on the Rust code because I don't know F-Star well enough and the shell scripts looked like they were copied from elsewhere.

I left a few comments. I am happy to discuss anything I wrote, in case you disagree.

libcrux-ml-dsa/src/types.rs Outdated Show resolved Hide resolved
libcrux-ml-dsa/src/types.rs Outdated Show resolved Hide resolved
libcrux-ml-dsa/src/simd/avx2.rs Show resolved Hide resolved
libcrux-ml-dsa/src/simd/avx2.rs Show resolved Hide resolved
libcrux-ml-dsa/src/simd/avx2.rs Show resolved Hide resolved
libcrux-ml-dsa/src/helper.rs Show resolved Hide resolved
@franziskuskiefer franziskuskiefer requested a review from keks December 9, 2024 18:02
@github-actions github-actions bot dismissed keks’s stale review December 9, 2024 18:11

Review re-requested

keks
keks approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@franziskuskiefer franziskuskiefer added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 767c2a7 Dec 10, 2024
53 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/mldsa-c1 branch December 10, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keks keks keks approved these changes

Assignees

@franziskuskiefer franziskuskiefer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franziskuskiefer @keks